Unicorn: Revert limitation of JPY only ( add limitation of accountId ) #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
changed the title
| @@ -191,8 +174,9 @@ func setSourceExt() json.RawMessage { | |||
| func setExt(request *openrtb2.BidRequest) (json.RawMessage, error) { | |||
| accountID, err := jsonparser.GetInt(request.Imp[0].Ext, "bidder", "accountId") | |||
| if err != nil { | |||
| accountID = 0 | |||
| return nil, fmt.Errorf("accountId field is required") | |||
There was a problem hiding this comment.
Can you please add coverage for this line?
There was a problem hiding this comment.
This line was not able to pass, so investigated it.
I found bug that acccountId set zero in modifyImps when not have accountId.
So i fixed it, and added test case that not have accountId.
This line is passed now.
… and add test case of no accountId
VeronikaSolovei9
approved these changes
Jun 21, 2022
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Jul 5, 2022
* 'master' of https://github.com/wwwyyy/prebid-server: Read imp[].ext.tid, fix PBJS 7.3.0 compatibility (prebid#2283) New Adapter: Kargo (prebid#2268) VIS.X updated endpoint parameters (prebid#2282) New Adapter: InfyTV (prebid#2278) Support adapters to set seat for a bid (prebid#2266) VIS.X: add X-Forwarded-For header (prebid#2279) Unicorn: Revert limitation of JPY only ( add limitation of accountId ) (prebid#2277)
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modifyImpswhen not have accountId.#2265 (comment)